netdev - Re: [PATCH v2 net-next 0/2] flow_dissector: Flow dissector fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170905.114504.207582830119826554.davem@davemloft.net>
Date:   Tue, 05 Sep 2017 11:45:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tom@...ntonium.net
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org,
        alex.popov@...ux.com
Subject: Re: [PATCH v2 net-next 0/2] flow_dissector: Flow dissector fixes

From: Tom Herbert <tom@...ntonium.net>
Date: Fri,  1 Sep 2017 14:04:10 -0700

> This patch set fixes some basic issues with __skb_flow_dissect function.
> 
> Items addressed:
>   - Cleanup control flow in the function; in particular eliminate a
>     bunch of goto's and implement a simplified control flow model
>   - Add limits for number of encapsulations and headers that can be
>     dissected
> 
> v2:
>   - Simplify the logic for limits on flow dissection. Just set the
>     limit based on the number of headers the flow dissector can
>     processes. The accounted headers includes encapsulation headers,
>     extension headers, or other shim headers.
> 
> Tested:
> 
> Ran normal traffic, GUE, and VXLAN traffic.

Applied, thanks Tom.