netdev - Re: [PATCH net-next RFC 2/2] tun: enable napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1504720895.15310.69.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 06 Sep 2017 11:01:35 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Petar Penkov <ppenkov@...gle.com>
Cc:     netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Mahesh Bandewar <maheshb@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>, davem@...emloft.net,
        ppenkov@...nford.edu
Subject: Re: [PATCH net-next RFC 2/2] tun: enable napi_gro_frags() for
 TUN/TAP driver

On Tue, 2017-09-05 at 15:35 -0700, Petar Penkov wrote:
> Add a TUN/TAP receive mode that exercises the napi_gro_frags()
> interface. This mode is available only in TAP mode, as the interface
> expects packets with Ethernet headers.
> 


Hi Petar, thanks a lot for this work.

I must confess I have to retract one feedback I gave while reviewing
your patches.


> +		local_bh_disable();
> +		data = napi_alloc_frag(fragsz);
> +		local_bh_enable();
> +		if (!data) {
> +			err = -ENOMEM;
> +			goto free;
> +		}
> +
> +		page = virt_to_page(data);
> +		offset = offset_in_page(data);

These two lines above indeed trigger too many problems in the kernel.
(Like the one you tried to cover here
https://patchwork.kernel.org/patch/9927927/ )

Please use for your next submission the code you originally had :

	page = virt_to_head_page(data);
	offset = data - page_address(page);


Thanks !