netdev - Re: [PATCH] tipc: remove unnecessary call to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d91eb01e-adee-8bce-d419-698020e0af28@windriver.com>
Date:   Wed, 6 Sep 2017 20:50:19 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     Kleber Sacilotto de Souza <kleber.souza@...onical.com>,
        <netdev@...r.kernel.org>
CC:     Jon Maloy <jon.maloy@...csson.com>
Subject: Re: [PATCH] tipc: remove unnecessary call to dev_net()

On 09/06/2017 05:08 PM, Kleber Sacilotto de Souza wrote:
> The net device is already stored in the 'net' variable, so no need to call
> dev_net() again.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@...onical.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/bearer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index 89cd061c4468..6d6395e0904e 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -661,7 +661,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
>  		break;
>  	case NETDEV_UNREGISTER:
>  	case NETDEV_CHANGENAME:
> -		bearer_disable(dev_net(dev), b);
> +		bearer_disable(net, b);
>  		break;
>  	}
>  	return NOTIFY_OK;
>