netdev - Re: [PATCH net 2/4] lan78xx: Add fixed_phy device support for LAN7801 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170906140233.GC11864@lunn.ch>
Date:   Wed, 6 Sep 2017 16:02:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Nisar.Sayed@...rochip.com
Cc:     davem@...emloft.net, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net 2/4] lan78xx: Add fixed_phy device support for
 LAN7801 device

On Wed, Sep 06, 2017 at 10:51:44AM +0000, Nisar.Sayed@...rochip.com wrote:
> From: Nisar Sayed <Nisar.Sayed@...rochip.com>
> 
> Add fixed_phy device support for LAN7801 device
> 
> When LAN7801 device connected to PHY Device which does not have
> MDIO/MDC access, fixex_phy device will be added.

Please try to find a way to do this without all the #ifdefs. They can
be acceptable in header files, but should be avoided in .c files.

   Andrew