netdev - Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  7 Sep 2017 16:40:27 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Luciano Coelho <luca@...lho.fi>
Cc:     torvalds@...ux-foundation.org, linux-wireless@...r.kernel.org,
        johannes@...solutions.net, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, netdev@...r.kernel.org,
        davem@...emloft.net, emmanuel.grumbach@...el.com,
        Luca Coelho <luciano.coelho@...el.com>
Subject: Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Luciano Coelho <luca@...lho.fi> wrote:

> From: Luca Coelho <luciano.coelho@...el.com>
> 
> The LEDS_CMD command is only supported in some newer FW versions
> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions
> (such as iwlwifi-8000C-27.ucode).
> 
> To fix this, check for a new bit in the FW capabilities TLV that tells
> when the command is supported.
> 
> Note that the current version of -31.ucode in linux-firmware.git
> (31.532993.0) does not have this capability bit set, so the LED won't
> work, even though this version should support it.  But we will update
> this firmware soon, so it won't be a problem anymore.
> 
> Fixes: 7089ae634c50 ("iwlwifi: mvm: use firmware LED command where applicable")
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Luca Coelho <luciano.coelho@...el.com>

Patch applied to wireless-drivers.git, thanks.

2eabc84d2f8e iwlwifi: mvm: only send LEDS_CMD when the FW supports it

-- 
https://patchwork.kernel.org/patch/9941719/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches