netdev - Re: [PATCH] ath10: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o9qmn3kr.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 7 Sep 2017 11:36:05 +0000
From:   Kalle Valo <kvalo@....qualcomm.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Colin Ian King <colin.king@...onical.com>,
        "bartosz.markowski@...to.com" <bartosz.markowski@...to.com>,
        Govind Singh <govinds@....qualcomm.com>,
        "Ryan Hsu" <ryanhsu@....qualcomm.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rajkumar Manoharan <rmanohar@....qualcomm.com>,
        Ashok Raj Nagarajan <arnagara@....qualcomm.com>,
        Ben Greear <greearb@...delatech.com>,
        "ath10k@...ts.infradead.org" <ath10k@...ts.infradead.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ath10: mark PM functions as __maybe_unused

Arnd Bergmann <arnd@...db.de> writes:

> When CONFIG_PM_SLEEP is disabled, we get a compile-time
> warning:
>
> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_suspend(struct device *dev)
>
> Rather than fixing the #ifdef, this just marks both functions
> as __maybe_unused, which is a more robust way to do this.
>
> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks. But the title should have "ath10k:", I'll fix that.

-- 
Kalle Valo