netdev - Re: [PATCH] iwlwifi: mvm: only send LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877exan0nq.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 07 Sep 2017 15:39:05 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     torvalds@...ux-foundation.org, Luca Coelho <luca@...lho.fi>
Cc:     linux-wireless@...r.kernel.org, johannes@...solutions.net,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        netdev@...r.kernel.org, davem@...emloft.net,
        emmanuel.grumbach@...el.com, Luca Coelho <luciano.coelho@...el.com>
Subject: Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Luca Coelho <luca@...lho.fi> writes:

> From: Luca Coelho <luciano.coelho@...el.com>
>
> The LEDS_CMD command is only supported in some newer FW versions
> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions
> (such as iwlwifi-8000C-27.ucode).
>
> To fix this, check for a new bit in the FW capabilities TLV that tells
> when the command is supported.
>
> Note that the current version of -31.ucode in linux-firmware.git
> (31.532993.0) does not have this capability bit set, so the LED won't
> work, even though this version should support it.  But we will update
> this firmware soon, so it won't be a problem anymore.
>
> Fixes: 7089ae634c50 ("iwlwifi: mvm: use firmware LED command where applicable")
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Luca Coelho <luciano.coelho@...el.com>

Linus, do you want to apply this directly or should we take it via the
normal route (wireless-drivers -> net)? If your prefer the latter when
I'm planning to submit this to Dave in a day or two and expecting it to
get to your tree in about a week, depending of course what is Dave's
schedule.

-- 
Kalle Valo