netdev - Re: [PATCH net 2/2] i40e: Avoid some useless variables and initializers in nvm functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1504746798.3922.80.camel@intel.com>
Date:   Wed, 06 Sep 2017 18:13:18 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Stefano Brivio <sbrivio@...hat.com>, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        Anjali Singhai Jain <anjali.singhai@...el.com>
Subject: Re: [PATCH net 2/2] i40e: Avoid some useless variables and
 initializers in nvm functions

On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:
> Fixes: 09f79fd49d94 ("i40e: avoid NVM acquire deadlock during NVM
> update")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_nvm.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)

This is NOT a fix, it is a coding style preference whether or not you
like multiple returns or a single return in functions.  I do not mind
picking this up for net-next (4.15 kernel), but this does not qualify
for a fix for Dave's net tree.
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)