lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Sep 2017 16:16:46 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Arnd Bergmann <arnd@...db.de> Cc: Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Florian Westphal <fw@...len.de>, "David S. Miller" <davem@...emloft.net>, Vishwanath Pai <vpai@...mai.com>, Josh Hunt <johunt@...mai.com>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division Hi Arnd, On Wed, Sep 6, 2017 at 9:57 PM, Arnd Bergmann <arnd@...db.de> wrote: > 64-bit division is expensive on 32-bit architectures, and > requires a special function call to avoid a link error like: > > net/netfilter/xt_hashlimit.o: In function `hashlimit_mt_common': > xt_hashlimit.c:(.text+0x1328): undefined reference to `__aeabi_uldivmod' > > In the case of hashlimit_mt_common, we don't actually need a > 64-bit operation, we can simply rewrite the function slightly > to make that clear to the compiler. > > Fixes: bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") > Signed-off-by: Arnd Bergmann <arnd@...db.de> Thanks, this fixes a similar issue (__udivdi3 undefined) on m68k. Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists