netdev - Re: [PATCH] net: ipv6: fix regression of no RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170907.191843.836588795188250550.davem@davemloft.net>
Date:   Thu, 07 Sep 2017 19:18:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mmanning@...cade.com
Cc:     netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after
 DAD failure

From: Mike Manning <mmanning@...cade.com>
Date: Mon,  4 Sep 2017 15:52:55 +0100

> Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative
> addresses") incorrectly assumes that no RTM_NEWADDR are sent for
> addresses in tentative state, as this does happen for the standard
> IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in
> addconf_dad_stop(). So as a result of this change, no RTM_DELADDR is
> sent after DAD failure for a link-local when strict DAD (accept_dad=2)
> is configured, or on the next admin down in other cases. The absence
> of this notification breaks backwards compatibility and causes problems
> after DAD failure if this notification was being relied on. The
> solution is to allow RTM_DELADDR to still be sent after DAD failure.
> 
> Fixes: f784ad3d79e5("ipv6: do not send RTM_DELADDR for tentative addresses")
> Signed-off-by: Mike Manning <mmanning@...cade.com>
> Cc: Mahesh Bandewar <maheshb@...gle.com>

Mahesh, please review this patch.