netdev - Re: [PATCH net] tcp: fix a request socket leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170908.160814.574433719450434783.davem@davemloft.net>
Date:   Fri, 08 Sep 2017 16:08:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alexei.starovoitov@...il.com
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: fix a request socket leak

From: Alexei Starovoitov <alexei.starovoitov@...il.com>
Date: Fri, 8 Sep 2017 15:59:23 -0700

> On Fri, Sep 08, 2017 at 12:44:47PM -0700, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>> 
>> While the cited commit fixed a possible deadlock, it added a leak
>> of the request socket, since reqsk_put() must be called if the BPF
>> filter decided the ACK packet must be dropped.
>> 
>> Fixes: d624d276d1dd ("tcp: fix possible deadlock in TCP stack vs BPF filter")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> ---
>> David, this is a stable candidate (linux-4.13 has this bug)
> 
> Thanks for the fix
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> .. since the fix makes sense to me and as a reminder not to forget
> to backport it as well :)

Applied and queued up for -stable.