netdev - Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170908085405.GB16834@amd>
Date:   Fri, 8 Sep 2017 10:54:05 +0200
From:   Pavel Machek <pavel@....cz>
To:     Tristram.Ha@...rochip.com
Cc:     andrew@...n.ch, muvarov@...il.com, nathan.leigh.conrad@...il.com,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Woojung.Huh@...rochip.com
Subject: Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add
 other KSZ switch drivers.

Hi!

> From: Tristram Ha <Tristram.Ha@...rochip.com>
> 
> This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code.
> 

Please wrap the lines from time to time...


> This patch set is against net-next.
> 
>  drivers/net/dsa/microchip/Makefile     |    2 +-
>  drivers/net/dsa/microchip/ksz9477.c    | 1317 ++++++++++++++++++++++++++++++++

We already have ksz_9477_reg.h. So should this be ksz_9477.c for consistency?

>  drivers/net/dsa/microchip/ksz_common.c | 1156 +---------------------------
>  drivers/net/dsa/microchip/ksz_priv.h   |  105 ++-
>  drivers/net/dsa/microchip/ksz_spi.c    |   13 +-
>  net/dsa/tag_ksz.c                      |   40 +-

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)