netdev - RE: [PATCH] mwifiex: remove unnecessary call to memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2017 01:36:50 +0000
From:   Xinming Hu <huxm@...vell.com>
To:     Himanshu Jha <himanshujha199640@...il.com>,
        "amitkarwar@...il.com" <amitkarwar@...il.com>
CC:     Nishant Sarmukadam <nishants@...vell.com>,
        Ganapathi Bhat <gbhat@...vell.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] mwifiex: remove unnecessary call to memset

Hi Himanshu,


> -----Original Message-----
> From: Himanshu Jha [mailto:himanshujha199640@...il.com]
> Sent: 2017年9月11日 20:46
> To: amitkarwar@...il.com
> Cc: Nishant Sarmukadam <nishants@...vell.com>; Ganapathi Bhat
> <gbhat@...vell.com>; Xinming Hu <huxm@...vell.com>;
> kvalo@...eaurora.org; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org; Himanshu Jha <himanshujha199640@...il.com>
> Subject: [EXT] [PATCH] mwifiex: remove unnecessary call to memset
> 
> External Email
> 
> ----------------------------------------------------------------------
> call to memset to assign 0 value immediately after allocating memory with
> kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value.
> 

Looks find to me, Thanks.

Regards,
Simon

> Semantic patch used to resolve this issue:
> 
> @@
> expression e,e2; constant c;
> statement S;
> @@
> 
>   e = kzalloc(e2, c);
>   if(e == NULL) S
> - memset(e, 0, e2);
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/scan.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c
> b/drivers/net/wireless/marvell/mwifiex/scan.c
> index c9d41ed..8838b88 100644
> --- a/drivers/net/wireless/marvell/mwifiex/scan.c
> +++ b/drivers/net/wireless/marvell/mwifiex/scan.c
> @@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(struct
> mwifiex_private *priv)
>  	if (!user_scan_cfg)
>  		return -ENOMEM;
> 
> -	memset(user_scan_cfg, 0, sizeof(*user_scan_cfg));
> -
>  	for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) {
>  		if (!priv->hidden_chan[id].chan_number)
>  			break;
> --
> 2.7.4