netdev - Re: [PATCH net 0/3] nfp: wait more carefully for card init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170913.093902.570914704132982694.davem@davemloft.net>
Date:   Wed, 13 Sep 2017 09:39:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net 0/3] nfp: wait more carefully for card init

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 13 Sep 2017 08:51:28 -0700

> The first patch is a small fix for flower offload, we need a whitelist
> of supported matches, otherwise the unsupported ones will be ignored.
> 
> The second and the third patch are adding wait/polling to the probe path.
> We had reports of driver failing probe because it couldn't find the 
> control process (NSP) on the card.  Turns out the NSP will only announce
> its existence after it's fully initialized.  Until now we assumed it 
> will be reachable, just not processing commands (hence we wait for
> a NOOP command to execute successfully).

Please build test your changes and look at what the compiler says:

drivers/net/ethernet/netronome/nfp/nfp_main.c: In function ‘nfp_fw_unload’:
drivers/net/ethernet/netronome/nfp/nfp_main.c:395:10: warning: ‘return’ with a value, in function returning void
   return err;
          ^~~
drivers/net/ethernet/netronome/nfp/nfp_main.c:388:13: note: declared here
 static void nfp_fw_unload(struct nfp_pf *pf)
             ^~~~~~~~~~~~~