netdev - Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170913120909.GA11820@lunn.ch>
Date:   Wed, 13 Sep 2017 14:09:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Allen Pais <allen.lkml@...il.com>
Cc:     linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org,
        linux-crypto@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        netdev@...r.kernel.org, megaraidlinux.pdl@...adcom.com,
        target-devel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

On Wed, Sep 13, 2017 at 01:02:14PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@...il.com>

Hi Allen

Although correct, if you look higher up the call chain, this appears
to be not so useful.

rlb_initialize() is only called by bond_alb_initialize(), and it
propagates the -1. That is only called by bond_open() with:

	if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB)))
		return -ENOMEM;

So you might want to also modify this code, to return the return
value, rather than use the hard coded ENOMEM.

Since you code is OK as far as it goes:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew