netdev - Re: [PATCH net] tcp: update skb->skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170915.143706.992734259378949259.davem@davemloft.net>
Date:   Fri, 15 Sep 2017 14:37:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     liujian56@...wei.com, edumazet@...gle.com, ycheng@...gle.com,
        hkchu@...gle.com, netdev@...r.kernel.org, weiyongjun1@...wei.com,
        wangkefeng.wang@...wei.com
Subject: Re: [PATCH net] tcp: update skb->skb_mstamp more carefully

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 13 Sep 2017 20:30:39 -0700

> From: Eric Dumazet <edumazet@...gl.com>
> 
> liujian reported a problem in TCP_USER_TIMEOUT processing with a patch
> in tcp_probe_timer() :
>       https://www.spinics.net/lists/netdev/msg454496.html
> 
> After investigations, the root cause of the problem is that we update
> skb->skb_mstamp of skbs in write queue, even if the attempt to send a
> clone or copy of it failed. One reason being a routing problem.
> 
> This patch prevents this, solving liujian issue.
> 
> It also removes a potential RTT miscalculation, since
> __tcp_retransmit_skb() is not OR-ing TCP_SKB_CB(skb)->sacked with
> TCPCB_EVER_RETRANS if a failure happens, but skb->skb_mstamp has
> been changed.
> 
> A future ACK would then lead to a very small RTT sample and min_rtt
> would then be lowered to this too small value.
> 
> Tested:
...
> Signed-off-by: Eric Dumazet <edumazet@...gl.com>
> Reported-by: liujian <liujian56@...wei.com>

Applied and queued up for -stable, thanks.