netdev - Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <649cd233-d9b8-478b-e742-5da469df8f26@gmail.com>
Date:   Sun, 17 Sep 2017 13:09:21 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Roman Yeryomin <leroi.lists@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup



On 09/17/2017 10:23 AM, Roman Yeryomin wrote:
> Changes from v1:
> - use GRO instead of increasing ring size
> - use NAPI_POLL_WEIGHT instead of defining own NAPI_WEIGHT
> - optimize rx descriptor flags processing

net-next is closed at the moment, but these look like reasonable
changes, I would just replace patch 7 with a patch that entirely drops
the driver specific version since that does not serve any purpose in the
context of an in-kernel driver.

Some nice clean-ups that you should also consider for future changes:

- reduce the duplication of tests/conditions in korina_send_packet(), a
lot of them are testing for the same things and setting the same
descriptor bits

- move korina_tx() to a NAPI context instead of working from hard
interrupt context

- get rid of the MIPS dma_cache_* calls and instead properly use the
DMA-API to allocate descriptors and invalidate/write-back skb->data

> 
> Roman Yeryomin (7):
>   net: korina: don't use overflow and underflow interrupts
>   net: korina: optimize rx descriptor flags processing
>   net: korina: use NAPI_POLL_WEIGHT
>   net: korina: use GRO
>   net: korina: whitespace cleanup
>   net: korina: update authors
>   net: korina: bump version
> 
>  drivers/net/ethernet/korina.c | 230 ++++++++++++++----------------------------
>  1 file changed, 78 insertions(+), 152 deletions(-)
> 

-- 
Florian