netdev - Re: [PATCH net-next 00/12] net: dsa: b53/bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24876029-5ebb-075e-3f02-50cf0856474f@gmail.com>
Date:   Mon, 18 Sep 2017 14:46:48 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org, davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups

On 09/18/2017 02:41 PM, Florian Fainelli wrote:
> Hi all,
> 
> This patch series is a first pass set of clean-ups to reduce the number of LOCs
> between b53 and bcm_sf2 and sharing as many functions as possible.
> 
> There is a number of additional cleanups queued up locally that require more
> thorough testing.

David, I just spotted a missing EXPORT_SYMBOL() in patch 8 that was not
flagged since I had temporarily disabled modular build, I will resubmit
this shortly after checking the other patches too. Thanks!

> 
> Thanks!
> 
> Florian Fainelli (12):
>   net: dsa: b53: Remove is_cpu_port()
>   net: dsa: b53: Make b53_enable_cpu_port() take a port argument
>   net: dsa: b53: Defer port enabling to calling port_enable
>   net: dsa: bcm_sf2: Defer port enabling to calling port_enable
>   net: dsa: b53: Use a macro to define I/O operations
>   net: dsa: b53: Move Broadcom header setup to b53
>   net: dsa: b53: Define EEE register page
>   net: dsa: b53: Move EEE functions to b53
>   net: dsa: b53: Wire-up EEE
>   net: dsa: b53: Export b53_imp_vlan_setup()
>   net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP
>   net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port
> 
>  drivers/net/dsa/b53/b53_common.c | 150 ++++++++++++++++++++++++++++++++----
>  drivers/net/dsa/b53/b53_priv.h   | 145 ++++++++---------------------------
>  drivers/net/dsa/b53/b53_regs.h   |  48 ++++++++++++
>  drivers/net/dsa/bcm_sf2.c        | 161 +++------------------------------------
>  drivers/net/dsa/bcm_sf2.h        |   2 -
>  drivers/net/dsa/bcm_sf2_cfp.c    |   6 +-
>  drivers/net/dsa/bcm_sf2_regs.h   |  11 ---
>  7 files changed, 227 insertions(+), 296 deletions(-)
> 


-- 
Florian