netdev - Re: [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to calling port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87377j3c8h.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Mon, 18 Sep 2017 17:53:18 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, andrew@...n.ch,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to calling port_enable

Florian Fainelli <f.fainelli@...il.com> writes:

> There is no need to configure the enabled ports once in b53_setup() and then a
> second time around when dsa_switch_ops::port_enable is called, just do it when
> port_enable is called which is better in terms of power consumption and
> correctness.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Great, my next step is to move up the ports enabling/disabling withing
DSA core. This patch helps going in that direction, thanks.

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>