netdev - Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59BFC699.1060009@iogearbox.net>
Date:   Mon, 18 Sep 2017 15:14:01 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Tobias Klauser <tklauser@...tanz.ch>,
        Alexei Starovoitov <ast@...nel.org>
CC:     John Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge_memlock

On 09/18/2017 03:03 PM, Tobias Klauser wrote:
> If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned
> regardless of the actual error produced by bpf_map_precharge_memlock.
> Fix it by passing on the error returned by bpf_map_precharge_memlock.
>
> Also return -EINVAL instead of -ENOMEM if the page count overflow check
> fails.
>
> This makes dev_map_alloc match the behavior of other bpf maps' alloc
> functions wrt. return values.
>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

(This would then need to go via net tree.)

Acked-by: Daniel Borkmann <daniel@...earbox.net>