netdev - Re: [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial lpm test implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59C141F2.10104@iogearbox.net>
Date:   Tue, 19 Sep 2017 18:12:34 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Craig Gallek <kraigatgoog@...il.com>,
        Daniel Mack <daniel@...que.org>,
        Alexei Starovoitov <ast@...com>,
        "David S . Miller" <davem@...emloft.net>
CC:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial
 lpm test implementation

On 09/18/2017 09:30 PM, Craig Gallek wrote:
> From: Craig Gallek <kraig@...gle.com>
>
> The 'trivial' lpm implementation in this test allows equivalent nodes
> to be added (that is, nodes consisting of the same prefix and prefix
> length).  For lookup operations, this is fine because insertion happens
> at the head of the (singly linked) list and the first, best match is
> returned.  In order to support deletion, the tlpm data structue must
> first enforce uniqueness.  This change modifies the insertion algorithm
> to search for equivalent nodes and remove them.  Note: the
> BPF_MAP_TYPE_LPM_TRIE already has a uniqueness invariant that is
> implemented as node replacement.
>
> Signed-off-by: Craig Gallek <kraig@...gle.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>