netdev - Re: [PATCH net] 8139too: revisit napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170918.205729.1447641244948185208.davem@davemloft.net>
Date:   Mon, 18 Sep 2017 20:57:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     ville.syrjala@...ux.intel.com, edumazet@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] 8139too: revisit napi_complete_done() usage

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 18 Sep 2017 13:03:43 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> It seems we have to be more careful in napi_complete_done()
> use. This patch is not a revert, as it seems we can
> avoid bug that Ville reported by moving the napi_complete_done()
> test in the spinlock section.
> 
> Many thanks to Ville for detective work and all tests.
> 
> Fixes: 617f01211baf ("8139too: use napi_complete_done()")
> Reported-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Tested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>

Applied and queued up for -stable.