netdev - RE: [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0401MB22607775B0B26322C759D719FF610@AM4PR0401MB2260.eurprd04.prod.outlook.com>
Date:   Wed, 20 Sep 2017 02:14:49 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Troy Kisky <troy.kisky@...ndarydevices.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     Fabio Estevam <fabio.estevam@....com>,
        "lznuaa@...il.com" <lznuaa@...il.com>
Subject: RE: [PATCH v4 2/3] net: fec: remove unused interrupt
 FEC_ENET_TS_TIMER

From: Troy Kisky <troy.kisky@...ndarydevices.com> Sent: Wednesday, September 20, 2017 8:33 AM
>FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no
>need to enable it.
>
>Signed-off-by: Troy Kisky <troy.kisky@...ndarydevices.com>
>Acked-by: Fugang Duan <fugang.duan@....com>
>
>---
>v4: Added Acked-by
>
>Signed-off-by: Troy Kisky <troy.kisky@...ndarydevices.com>
>---

Troy, thank you for submitting the version.
The patch series had been already acked by me.

Thanks again.

> drivers/net/ethernet/freescale/fec.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/freescale/fec.h
>b/drivers/net/ethernet/freescale/fec.h
>index 38c7b21..ede1876 100644
>--- a/drivers/net/ethernet/freescale/fec.h
>+++ b/drivers/net/ethernet/freescale/fec.h
>@@ -374,8 +374,8 @@ struct bufdesc_ex {
> #define FEC_ENET_TS_AVAIL       ((uint)0x00010000)
> #define FEC_ENET_TS_TIMER       ((uint)0x00008000)
>
>-#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF |
>FEC_ENET_MII | FEC_ENET_TS_TIMER)
>-#define FEC_NAPI_IMASK	(FEC_ENET_MII | FEC_ENET_TS_TIMER)
>+#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF |
>FEC_ENET_MII)
>+#define FEC_NAPI_IMASK	FEC_ENET_MII
> #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK &
>(~FEC_ENET_RXF))
>
> /* ENET interrupt coalescing macro define */
>--
>2.7.4