netdev - Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59C2DCAD.3090309@iogearbox.net>
Date:   Wed, 20 Sep 2017 23:25:01 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Joel Fernandes <joelaf@...gle.com>, linux-kernel@...r.kernel.org
CC:     netdev@...r.kernel.org, alison@...-devel.com, juri.lelli@....com,
        fengc@...gle.com, davem@...emloft.net, ast@...nel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling

On 09/20/2017 06:11 PM, Joel Fernandes wrote:
> BPF samples fail to build when cross-compiling for ARM64 because of incorrect
> pt_regs param selection. This is because clang defines __x86_64__ and
> bpf_headers thinks we're building for x86. Since clang is building for the BPF
> target, it shouldn't make assumptions about what target the BPF program is
> going to run on. To fix this, lets pass ARCH so the header knows which target
> the BPF program is being compiled for and can use the correct pt_regs code.
>
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> Signed-off-by: Joel Fernandes <joelaf@...gle.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>