netdev - [PATCH 32/64] drivers: net: amd: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1506013525-29291-33-git-send-email-allen.lkml@gmail.com>
Date:   Thu, 21 Sep 2017 22:34:53 +0530
From:   Allen Pais <allen.lkml@...il.com>
To:     netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, m.grzeschik@...gutronix.de,
        dmitry.tarnyagin@...kless.no, wg@...ndegger.com,
        mkl@...gutronix.de, mark.einon@...il.com, linux@...linux.org.uk,
        pcnet32@...ntier.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, venza@...wnhat.org,
        ajk@...nets.uni-bremen.de, jes@...ined-monkey.org,
        romieu@...zoreil.com, khc@...waw.pl, simon@...kelleys.org.uk,
        davem@...emloft.net, linux-can@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        Allen Pais <allen.lkml@...il.com>
Subject: [PATCH 32/64] drivers: net: amd: use setup_timer() helper.

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@...il.com>
---
 drivers/net/ethernet/amd/sunlance.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c
index 291ca51..0183ffb 100644
--- a/drivers/net/ethernet/amd/sunlance.c
+++ b/drivers/net/ethernet/amd/sunlance.c
@@ -1459,9 +1459,8 @@ static int sparc_lance_probe_one(struct platform_device *op,
 	 * can occur from interrupts (ex. IPv6).  So we
 	 * use a timer to try again later when necessary. -DaveM
 	 */
-	init_timer(&lp->multicast_timer);
-	lp->multicast_timer.data = (unsigned long) dev;
-	lp->multicast_timer.function = lance_set_multicast_retry;
+	setup_timer(&lp->multicast_timer, lance_set_multicast_retry,
+		    (unsigned long)dev);
 
 	if (register_netdev(dev)) {
 		printk(KERN_ERR "SunLance: Cannot register device.\n");
-- 
2.7.4