netdev - Re: [PATCH net] net: qualcomm: rmnet: Fix rcu splat in rmnet_is_real_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Sep 2017 20:00:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     subashab@...eaurora.org
Cc:     xiaolong.ye@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: qualcomm: rmnet: Fix rcu splat in
 rmnet_is_real_dev_registered

From: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Date: Thu, 21 Sep 2017 18:00:36 -0600

> Xiaolong reported a suspicious rcu_dereference_check in the device
> unregister notifier callback. Since we do not dereference the
> rx_handler_data, it's ok to just check for the value of the pointer.
> Note that this section is already protected by rtnl_lock.
 ...
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> Reported-by: kernel test robot <xiaolong.ye@...el.com>

Applied, thank you.