netdev - Re: [PATCH] lib: fix multiple strlcpy definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170926162745.kxl3m42hfprhqhd3@tarshish>
Date:   Tue, 26 Sep 2017 19:27:45 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Phil Sutter <phil@....cc>,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] lib: fix multiple strlcpy definition

Hi Phil,

On Tue, Sep 26, 2017 at 05:55:24PM +0200, Phil Sutter wrote:
> On Tue, Sep 26, 2017 at 02:08:49PM +0300, Baruch Siach wrote:
> [...]
> > diff --git a/configure b/configure
> > index 7be8fb113cc9..787b2e061af9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -326,6 +326,27 @@ EOF
> >      rm -f $TMPDIR/dbtest.c $TMPDIR/dbtest
> >  }
> >  
> > +check_strlcpy()
> > +{
> > +    cat >$TMPDIR/strtest.c <<EOF
> > +#include <string.h>
> > +int main(int argc, char **argv) {
> > +	char dst[10];
> > +	strlcpy("test", dst, sizeof(dst));
> 
> You swapped source and destination here. It's not important for the
> given use-case, but the resulting binary should segfault.

Will fix that in v2.

> Apart from that, LGTM!

Thanks. I'll take this as an ack.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -