netdev - Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170925.201944.383866196624108211.davem@davemloft.net>
Date:   Mon, 25 Sep 2017 20:19:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jiri@...nulli.us, mchehab@...nel.org, arend.vanspriel@...adcom.com,
        kvalo@...eaurora.org, aryabinin@...tuozzo.com, glider@...gle.com,
        dvyukov@...gle.com, yamada.masahiro@...ionext.com, mmarek@...e.com,
        akpm@...ux-foundation.org, keescook@...omium.org,
        geert@...ux-m68k.org, gregkh@...uxfoundation.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, kasan-dev@...glegroups.com,
        linux-kbuild@...r.kernel.org, jakub@....gnu.org,
        marxin@....gnu.org, stable@...r.kernel.org
Subject: Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 22 Sep 2017 23:29:18 +0200

> Inlining these functions creates lots of stack variables that each take
> 64 bytes when KASAN is enabled, leading to this warning about potential
> stack overflow:
> 
> drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_cmd_flow_tbl_add':
> drivers/net/ethernet/rocker/rocker_ofdpa.c:621:1: error: the frame size of 2752 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
> 
> gcc-8 can now consolidate the stack slots itself, but on older versions
> we get the same behavior by using a temporary variable that holds a
> copy of the inline function argument.
> 
> Cc: stable@...r.kernel.org
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.