netdev - Re: [PATCH 2/2] neigh: make strucrt neigh_table::entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170925.203652.2254718838332266992.davem@davemloft.net>
Date:   Mon, 25 Sep 2017 20:36:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     adobriyan@...il.com
Cc:     netdev@...r.kernel.org, ganeshgr@...lsio.com
Subject: Re: [PATCH 2/2] neigh: make strucrt neigh_table::entry_size
 unsigned int

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Sat, 23 Sep 2017 23:03:04 +0300

> Key length can't be negative.
> 
> Leave comparisons against nla_len() signed just in case truncated attribute
> can sneak in there.
> 
> Space savings:
> 
> 	add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-7 (-7)
> 	function                                     old     new   delta
> 	pneigh_delete                                273     272      -1
> 	mlx5e_rep_netevent_event                    1415    1414      -1
> 	mlx5e_create_encap_header_ipv6              1194    1193      -1
> 	mlx5e_create_encap_header_ipv4              1071    1070      -1
> 	cxgb4_l2t_get                               1104    1103      -1
> 	__pneigh_lookup                               69      68      -1
> 	__neigh_create                              2452    2451      -1
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Applied.