lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Sep 2017 20:03:39 -0700 (PDT) From: David Miller <davem@...emloft.net> To: devtimhansen@...il.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974. From: Tim Hansen <devtimhansen@...il.com> Date: Tue, 26 Sep 2017 20:54:05 -0400 > Signed-off-by: Tim Hansen <devtimhansen@...il.com> This is a poor patch submission on many levels. But the main problem, is that there is no use of sk_for_each_entry_offset_rcu() in any of my networking kernel trees. Referencing code by line number never works, you have to mention what version of the kernel, what tree, and where in what fucntion the problem is occurring. Secondly, sk_for_each_entry_offset_rcu() is not meant to be used in _raw() contexts. This is why it's not called sk_for_each_entry_offset_rcu_raw(). The sparse warning is probably legitimate, and points to a bug. But nobody can tell where becuase you haven't told us what tree and where this happens.
Powered by blists - more mailing lists