netdev - Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

Open Source and information security mailing list archives

Message-ID: <87shf6hlcc.fsf@free-electrons.com>
Date:   Thu, 28 Sep 2017 17:52:19 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Jason Cooper <jason@...edaemon.net>, netdev@...r.kernel.org,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Omri Itach <omrii@...vell.com>, linux-kernel@...r.kernel.org,
        Nadav Haklai <nadavh@...vell.com>,
        Shadi Ammouri <shadi@...vell.com>,
        Igal Liberman <igall@...vell.com>,
        Miquèl Raynal <miquel.raynal@...e-electrons.com>,
        Hanna Hawa <hannah@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-arm-kernel@...ts.infradead.org,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

Hi Thomas,

 On jeu., sept. 28 2017, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> wrote:

>>  	/* List of pointers to port structures */
>>  	struct mvpp2_port **port_list;
>> @@ -7963,6 +7964,16 @@ static int mvpp2_probe(struct platform_device *pdev)
>>  		err = clk_prepare_enable(priv->mg_clk);
>>  		if (err < 0)
>>  			goto err_gop_clk;
>> +
>> +		priv->axi_clk = devm_clk_get(&pdev->dev, "axi_clk");
>> +		if (IS_ERR(priv->axi_clk)) {
>> +			err = PTR_ERR(priv->axi_clk);
>> +			priv->axi_clk = NULL;
>
> You should handle -EPROBE_DEFER here. Indeed, if we have -EPROBE_DEFER,
> we shouldn't treat it as "the clock doesn't exist, so let's skip it and
> continue", but rather as "the clock exists, but isn't ready to use yet,
> let's try later".

You're totally right, I will send a v2 (I will also fix the other issue
you spotted).

Thanks,

Gregory

>
> Thanks!
>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives