netdev - Re: [PATCH] net-ipv6: remove unused IP6_ECN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170928.104857.2113645025730852044.davem@davemloft.net>
Date:   Thu, 28 Sep 2017 10:48:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     maze@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net-ipv6: remove unused IP6_ECN_clear() function

From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Tue, 26 Sep 2017 20:37:22 -0700

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> This function is unused, and furthermore it is buggy since it suffers
> from the same issue that requires IP6_ECN_set_ce() to take a pointer
> to the skb so that it may (in case of CHECKSUM_COMPLETE) update skb->csum
> 
> Instead of fixing it, let's just outright remove it.
> 
> Tested: builds, and 'git grep IP6_ECN_clear' comes up empty
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Applied to net-next.