netdev - Re: [PATCH] mkiss: remove redundant check on len being zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170930.054454.1056054589514297047.davem@davemloft.net>
Date:   Sat, 30 Sep 2017 05:44:54 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     stephen@...workplumber.org, johannes.berg@...el.com,
        ralf@...ux-mips.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mkiss: remove redundant check on len being zero

From: Colin King <colin.king@...onical.com>
Date: Wed, 27 Sep 2017 22:45:13 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The check on len is redundant as it is always greater than 1,
> so just remove it and make the printk less complex.
> 
> Detected by CoverityScan, CID#1226729 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.