netdev - Re: [PATCH net v1 1/1] tipc: use only positive error codes in messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171001.040434.1155203728534988379.davem@davemloft.net>
Date:   Sun, 01 Oct 2017 04:04:34 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...csson.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com,
        parthasarathy.bhuvaragan@...il.com
Subject: Re: [PATCH net v1 1/1] tipc: use only positive error codes in
 messages

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
Date: Fri, 29 Sep 2017 10:02:54 +0200

> In commit e3a77561e7d32 ("tipc: split up function tipc_msg_eval()"),
> we have updated the function tipc_msg_lookup_dest() to set the error
> codes to negative values at destination lookup failures. Thus when
> the function sets the error code to -TIPC_ERR_NO_NAME, its inserted
> into the 4 bit error field of the message header as 0xf instead of
> TIPC_ERR_NO_NAME (1). The value 0xf is an unknown error code.
> 
> In this commit, we set only positive error code.
> 
> Fixes: e3a77561e7d32 ("tipc: split up function tipc_msg_eval()")
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>

Applied and queued up for -stable, thanks.