netdev - Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171001.040828.1047378292144214219.davem@davemloft.net>
Date:   Sun, 01 Oct 2017 04:08:28 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

From: Colin King <colin.king@...onical.com>
Date: Fri, 29 Sep 2017 15:01:16 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment of -EINVAL to variable ret is redundant as it
> is being overwritten on the following error exit paths or
> to the return value from the following call to basic_set_parms.
> Fix this up by removing it. Cleans up clang warning message:
> 
> net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.