netdev - Re: [PATCH net] ip_gre: ipgre_tap device should keep dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 01 Oct 2017 03:54:47 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, xeb@...l.ru
Subject: Re: [PATCH net] ip_gre: ipgre_tap device should keep dst

From: Xin Long <lucien.xin@...il.com>
Date: Thu, 28 Sep 2017 13:23:31 +0800

> Without keeping dst, the tunnel will not update any mtu/pmtu info,
> since it does not have a dst on the skb.
> 
> Reproducer:
>   client(ipgre_tap1 - eth1) <-----> (eth1 - ipgre_tap1)server
> 
> After reducing eth1's mtu on client, then perforamnce became 0.
> 
> This patch is to netif_keep_dst in gre_tap_init, as ipgre does.
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable.