netdev - Re: [PATCH net-next] net: core: decouple ifalias get/set from rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171001.224644.903150013683866978.davem@davemloft.net>
Date:   Sun, 01 Oct 2017 22:46:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] net: core: decouple ifalias get/set from rtnl
 lock

From: Florian Westphal <fw@...len.de>
Date: Fri, 29 Sep 2017 13:21:50 +0200

> @@ -1488,7 +1484,7 @@ static void netdev_release(struct device *d)
>  
>  	BUG_ON(dev->reg_state != NETREG_RELEASED);
>  
> -	kfree(dev->ifalias);
> +	kfree(rcu_access_pointer(dev->ifalias));
>  	netdev_freemem(dev);
>  }
>  

"kfree_rcu()" at least?

If the deal is that you don't need to do and RCU free because
netdevice objects disappear synchronously, and you can therefore prove
that no RCU based async access can occur to dev->ifalias, then you
need to add a comment here.