netdev - RE: [net-next 11/15] i40evf: Enable VF to request an alternate queue allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C8326AE922E1A04D91DF73B4913A8DCB2CA550D7@ORSMSX108.amr.corp.intel.com>
Date:   Mon, 2 Oct 2017 21:35:51 +0000
From:   "Brady, Alan" <alan.brady@...el.com>
To:     Yuval Mintz <yuvalm@...lanox.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jogreene@...hat.com" <jogreene@...hat.com>
Subject: RE: [net-next 11/15] i40evf: Enable VF to request an alternate
 queue allocation

> -----Original Message-----
> From: Yuval Mintz [mailto:yuvalm@...lanox.com]
> Sent: Monday, October 2, 2017 1:51 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; davem@...emloft.net
> Cc: Brady, Alan <alan.brady@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; jogreene@...hat.com
> Subject: RE: [net-next 11/15] i40evf: Enable VF to request an alternate queue
> allocation
> 
> > +	case VIRTCHNL_OP_REQUEST_QUEUES: {
> > +		struct virtchnl_vf_res_request *vfres =
> > +			(struct virtchnl_vf_res_request *)msg;
> > +		if (vfres->num_queue_pairs == adapter->num_req_queues)
> > {
> > +			adapter->flags |=
> > I40EVF_FLAG_REINIT_ITR_NEEDED;
> > +			i40evf_schedule_reset(adapter);
> > +		} else {
> > +			dev_info(&adapter->pdev->dev,
> > +				 "Requested %d queues, PF can support
> > %d\n",
> > +				 adapter->num_req_queues,
> > +				 vfres->num_queue_pairs);
> > +			adapter->num_req_queues = 0;
> > +		}
> > +		}
> > +		break;
> 
> Something is odd about your parenthesis.
> 
> >  	default:
> >  		if (adapter->current_op && (v_opcode != adapter-
> > >current_op))
> >  			dev_warn(&adapter->pdev->dev, "Expected
> response %d from PF,
> > received %d\n",
> > --
> > 2.14.2

I'm not sure which parentheses you are referring to.  Perhaps you mean the double curly braces?  The outer set of braces are creating a block in the case statement so we can declare a variable specific to the case statement.  The inner brace is an if/else statement block.  They are both consistent with brace usage/alignment in the rest of the file and adding a new line between them generates a GCC warning.

-Alan