netdev - Re: [PATCH net-next] ibmvnic: Improve output for unsupported stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171002.160347.373058501691864578.davem@davemloft.net>
Date:   Mon, 02 Oct 2017 16:03:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     jallen@...ux.vnet.ibm.com, netdev@...r.kernel.org,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Improve output for unsupported stats

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 2 Oct 2017 23:57:23 +0200

> On Mon, Oct 02, 2017 at 03:31:39PM -0500, John Allen wrote:
>> The vnic server can report -1 in the event that a given statistic is not
>> supported. Currently, the -1 value is implicitly cast to an unsigned
>> integer and appears through the ethtool -S output as a very large number.
>> This patch improves this behavior by reporting 0 in the event that a
>> given statistic is not supported.
> 
> Hi John
> 
> If it does not exist, why not skip it altogether?
> ibmvnic_get_sset_count() could walk the list and count the valid ones.
> ibmvnic_get_strings() could only return the name of the valid onces.

Agreed, skipping would be preferable to printing zero values.