netdev - Re: [PATCH] net: hns3: Fix an error handling path in 'hclge_rss_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171001.225743.584554872378988701.davem@davemloft.net>
Date:   Sun, 01 Oct 2017 22:57:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        linyunsheng@...wei.com, lipeng321@...wei.com,
        colin.king@...onical.com, arnd@...db.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: hns3: Fix an error handling path in
 'hclge_rss_init_hw()'

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sat, 30 Sep 2017 07:34:34 +0200

> If this sanity check fails, we must free 'rss_indir'. Otherwise there is a
> memory leak.
> 'goto err' as done in the other error handling paths to fix it.
> 
> Fixes: 46a3df9f9718 ("net: hns3: Fix for setting rss_size incorrectly")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.