netdev - Re: [PATCH net] net: rtnetlink: fix info leak in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171003.101918.592253533156020512.davem@davemloft.net>
Date:   Tue, 03 Oct 2017 10:19:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, keescook@...omium.org, dvyukov@...gle.com,
        andreyknvl@...gle.com, kcc@...gle.com, roopa@...ulusnetworks.com,
        glider@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] net: rtnetlink: fix info leak in RTM_GETSTATS call

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Tue,  3 Oct 2017 13:20:48 +0300

> When RTM_GETSTATS was added the fields of its header struct were not all
> initialized when returning the result thus leaking 4 bytes of information
> to user-space per rtnl_fill_statsinfo call, so initialize them now. Thanks
> to Alexander Potapenko for the detailed report and bisection.
> 
> Reported-by: Alexander Potapenko <glider@...gle.com>
> Fixes: 10c9ead9f3c6 ("rtnetlink: add new RTM_GETSTATS message to dump link stats")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied and queued up for -stable, thanks.