netdev - Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171003.145418.677435703318514230.davem@davemloft.net>
Date:   Tue, 03 Oct 2017 14:54:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shmulik@...f.io
Cc:     netdev@...r.kernel.org, mateusz.bajorski@...ia.com,
        dsa@...ulusnetworks.com, tgraf@...g.ch, shmulik.ladkani@...il.com
Subject: Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare
 implementations to support exact match

From: Shmulik Ladkani <shmulik@...f.io>
Date: Sat, 30 Sep 2017 11:59:09 +0300

> This leads to inconsistencies, depending on order of operations, e.g.:

I don't see any inconsistency.  When you insert using NLM_F_EXCL the
insertion fails if any existing rule matches or overlaps in any way
with the keys in the new rule.

Sorry I'm not going to apply this.