netdev - Re: [PATCH net-next] selftests: rtnetlink: try concurrent change of ifalias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507126593.14419.0.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 04 Oct 2017 07:16:33 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: rtnetlink: try concurrent change of
 ifalias

On Wed, 2017-10-04 at 13:52 +0200, Florian Westphal wrote:
> to make sure this is serialized correctly.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 62c87da92770..13c29beb5769 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -278,6 +278,14 @@ kci_test_ifalias()
>  	        ip link show "$devdummy" | grep -q "alias $namewant"
>  		check_fail $?
>  
> +		for i in $(seq 1 100); do
> +			uuidgen > "$syspathname" &
> +		done
> +
> +		for i in $(seq 1 100); do
> +			wait
> +		done
> +

A single wait is enough, you do not need a loop.