netdev - Re: [PATCH 5/5] VSOCK: add tools/vsock/vsock_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171004150533.GD3840@stefanha-x1.localdomain>
Date:   Wed, 4 Oct 2017 11:05:33 -0400
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jhansen@...are.com, decui@...rosoft.com
Subject: Re: [PATCH 5/5] VSOCK: add tools/vsock/vsock_diag_test

On Tue, Oct 03, 2017 at 09:48:05PM -0700, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@...hat.com>
> Date: Tue,  3 Oct 2017 11:39:43 -0400
> 
> >  MAINTAINERS                   |   1 +
> >  tools/vsock/Makefile          |   9 +
> >  tools/vsock/control.h         |  13 +
> >  tools/vsock/timeout.h         |  14 +
> >  tools/vsock/control.c         | 219 ++++++++++++++
> >  tools/vsock/timeout.c         |  64 ++++
> >  tools/vsock/vsock_diag_test.c | 681 ++++++++++++++++++++++++++++++++++++++++++
> >  tools/vsock/.gitignore        |   2 +
> 
> Please don't create you own "special" directory for tests.
> 
> Tests belong under tools/testing/selftests/
> 
> If you put your tests in the proper place, and structure them properly (especially
> the Makefile rules), they will automatically be run by various automated build
> and test frameworks.

Cool, thanks for the hint.  I wasn't aware of that.

Will fix in v2.

Stefan