netdev - Re: [PATCH net-next 1/2] tcp: uniform the set up of sockets after successful connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Oct 2017 21:28:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        edumazet@...gle.com
Subject: Re: [PATCH net-next 1/2] tcp: uniform the set up of sockets after
 successful connection

From: Wei Wang <weiwan@...gle.com>
Date: Mon,  2 Oct 2017 10:01:35 -0700

> @@ -456,6 +456,19 @@ void tcp_init_sock(struct sock *sk)
>  }
>  EXPORT_SYMBOL(tcp_init_sock);
>  
> +void tcp_init_transfer(struct sock *sk, int bpf_op)
> +{
> +	struct inet_connection_sock *icsk = inet_csk(sk);
> +
> +	tcp_mtup_init(sk);
> +	icsk->icsk_af_ops->rebuild_header(sk);
> +	tcp_init_metrics(sk);
> +	tcp_call_bpf(sk, bpf_op);
> +	tcp_init_congestion_control(sk);
> +	tcp_init_buffer_space(sk);
> +}
> +EXPORT_SYMBOL(tcp_init_transfer);

This symbol export is unnecessary, and if it were it should
be EXPORT_SYMBOL_GPL().