netdev - Re: [PATCH RESEND net 0/9] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Oct 2017 21:41:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fthain@...egraphics.com.au
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND net 0/9] Fixes, cleanup and modernization for
 some legacy ethernet NIC drivers

From: Finn Thain <fthain@...egraphics.com.au>
Date: Mon,  2 Oct 2017 21:07:17 -0400 (EDT)

> This patch series fixes some logging bugs and adds some missing message
> severity levels.
> 
> There are also cleanup patches for dead code and some Kconfig cruft.
> 
> Custom debug message logging is converted to netif_* calls to reduce
> code duplication.
> 
> All up, about 150 lines of code are eliminated.
> 
> My apologies for duplicated messages. I messed up the addressing.

Finn, I'm finding real bugs in this series and seriously if you cannot
test these changes in some way please leave this code alone.

For example, you're removing the "once_is_enough" logic from
mac89x0_probe().

But you can't do that.  The probe function can in fact be called
multiple times, from drivers/net/Space.c  It gets called in a loop
iterating over different 'unit' argument values.

Unless you're making stylistic changes where you can prove the object
code resulting is still the same, you really should not be playing
with fire by trying to remove "dead code" like this in legacy drivers
you cannot fully test.

Thank you.