netdev - Re: [PATCH] isdn/gigaset: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171005.095309.1742522481534840543.davem@davemloft.net>
Date:   Thu, 05 Oct 2017 09:53:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pebolle@...cali.nl
Cc:     keescook@...omium.org, isdn@...ux-pingi.de, johan@...nel.org,
        gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()

From: Paul Bolle <pebolle@...cali.nl>
Date: Thu, 05 Oct 2017 09:58:56 +0200

> Hi Kees,
> 
> On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote:
>> Also uses kzmalloc to replace open-coded field assignments to NULL and zero.
> 
> If I'm allowed to whine (chances that I'm allowed to do that are not so great
> as Dave tends to apply gigaset patches before I even have a chance to look at
> them properly!): I'd prefer it if that was done separately in a preceding
> patch. Would that bother you? 

Agreed, these timer transformations are already exhausting to review without
unrelated modifications sneaking in.