netdev - Re: [PATCH] net: 8021q: skip packets if the vlan is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171004.182329.616816521170306524.davem@davemloft.net>
Date:   Wed, 04 Oct 2017 18:23:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Vishakha.Narvekar@...l.com
Cc:     netdev@...r.kernel.org, allen.hubbe@...l.com, andrew.boyer@...l.com
Subject: Re: [PATCH] net: 8021q: skip packets if the vlan is down

From: Vishakha Narvekar <Vishakha.Narvekar@...l.com>
Date: Tue,  3 Oct 2017 16:13:29 -0400

> If the vlan is down, free the packet instead of proceeding with other
> processing, or counting it as received.  If vlan interfaces are used
> as slaves for bonding, with arp monitoring for connectivity, if the rx
> counter is seen to be incrementing, then the bond device will not
> observe that the interface is down.
> 
> CC: David S. Miller <davem@...emloft.net>
> Signed-off-by: Vishakha Narvekar <Vishakha.Narvekar@...l.com>

I've applied this for now.

This is likely the best we can do in the software case.

In the hardware offload case, we really should (via the notifier for
the vlan device going down), tell the hardware to stop receiving vlan
packets.