netdev - Re: [patch net-next 2/2] mlxsw: spectrum: Propagate extack further for bridge enslavements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c678acc9-940a-b0e0-ba27-a34b19fcf13e@gmail.com>
Date:   Fri, 6 Oct 2017 12:24:43 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next 2/2] mlxsw: spectrum: Propagate extack further
 for bridge enslavements

On 10/5/17 3:40 PM, Jiri Pirko wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> The code that actually takes care of bridge offload introduces a few
> more non-trivial constraints with regards to bridge enslavements.
> Propagate extack there to indicate the reason.
> 
> $ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10
> $ ip link add link enp1s0np1 name enp1s0np1.20 type vlan id 20
> $ ip link add name br0 type bridge
> $ ip link set dev enp1s0np1.10 master br0
> $ ip link set dev enp1s0np1.20 master br0
> Error: spectrum: Can not bridge VLAN uppers of the same port.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum.c     |  6 ++++--
>  drivers/net/ethernet/mellanox/mlxsw/spectrum.h     |  3 ++-
>  .../ethernet/mellanox/mlxsw/spectrum_switchdev.c   | 25 +++++++++++++++-------
>  3 files changed, 23 insertions(+), 11 deletions(-)

Acked-by: David Ahern <dsahern@...il.com>