netdev - Re: [PATCH net] net: enable interface alias removal via rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6bd73fe-9b60-6741-8a6d-c93f6ee64a40@hartkopp.net>
Date:   Fri, 6 Oct 2017 22:10:42 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     David Ahern <dsahern@...il.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, Oliver Hartkopp <oliver@...tkopp.net>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net] net: enable interface alias removal via rtnl



On 10/06/2017 08:18 PM, David Ahern wrote:
> On 10/5/17 4:19 AM, Nicolas Dichtel wrote:
>> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
>> the attribute is 1 ("\0"). However, to remove an alias, the attribute
>> length must be 0 (see dev_set_alias()).
> 
> why not add a check in dev_set_alias that if len is 1 and the 1
> character is '\0' it means remove the alias?

Yes. That looks indeed better than changing NLA_STRING to NLA_BINARY 
which does not really hit the point.

Nicolas, can you send an updated patch picking up David's suggestion?

Tnx & best regards,
Oliver

> 
>>
>> Let's define the type to NLA_BINARY, so that the alias can be removed.
> 
> that changes the uapi
>